Internal: Improve loading time in courseHome page - refs BT#21784 #5589
Conversation
|
Code Climate has analyzed commit 60cd1e4 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -250,11 +263,11 @@ class Session implements ResourceWithAccessUrlInterface, Stringable | |||
| #[ORM\Column(name: 'duration', type: 'integer', nullable: true)] | |||
| protected ?int $duration = null; | |||
|
|
|||
| #[Groups(['session:read'])] | |||
| #[Groups(['session:basic', 'session:read'])] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| #[ORM\Column(name: 'nbr_courses', type: 'integer', unique: false, nullable: false)] | ||
| protected int $nbrCourses; | ||
|
|
||
| #[Groups(['session:read'])] | ||
| #[Groups(['session:basic', 'session:read'])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| params: { | ||
| 'groups[]': groups | ||
| } |
There was a problem hiding this comment.
El GroupFilter no está configurado en la clase Session. Entonces, no sería necesario pasarlo en params ya que estás poniendo el grupo en otro endpoint.
Aunque usar GroupFilter en Session sería una opción para no tener otro endpoint
assets/vue/store/cidReq.js
Outdated
There was a problem hiding this comment.
En el cidReqStore podría estar useBasic a true por defecto, ya que cidReq es solo para traer la info necesaria de la sesión
No description provided.